Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.x.x backport request: Add a fallback for Chrome dev tools strange behavior #210

Closed
wants to merge 1 commit into from
Closed

v1.x.x backport request: Add a fallback for Chrome dev tools strange behavior #210

wants to merge 1 commit into from

Conversation

loklaan
Copy link

@loklaan loklaan commented Jun 13, 2016

This pr aims to backport an already implemented fix (see #186) to the 1.x.x version track, for a breaking change introduced by the current stable version of Chrome.

There doesn't seem to be a 1.x.x version track for core-js, but I thought I'd try to this request anyway. 😉

This could be seen as a critical bugfix, since babel 5.x.x still uses the core-js in the ^1.0.0 range. I can imagine quite a few devs who are maintaining an app with babel 5.x.x would appreciate this backport.

Also, thanks for the original fix! You've made it easy to apply a temporary hotfix to my own app.

Note: I don't intend this pr to actually be merged into master. Perhaps you could create a 1.x.x branch, if you go ahead with this pr?

@loklaan loklaan mentioned this pull request Jun 13, 2016
Closed
@loklaan
Copy link
Author

loklaan commented Jun 14, 2016

Update on this PR (I am closing it).

This approach may still be useful to some people that currently have issues with devtools in Chrome, that have to work with core-js v1.x.x.

But, the issue with Babel 5.x.x that drove me to organise this PR doesn't actually exist... I was simply led astray by my own false conclusions after debugging the overall issue. The latest babel-polyfill is using an up-to-date core-js, which should resolve this devtools error.

Also, to those that are led here for similar reasons as mine were to create this PR, you should know that upgrading from babel 5 to babel 6 isn't that terrible. I recommend these two articles for getting a quick grok on potential downfalls.

@loklaan loklaan closed this Jun 14, 2016
@loganfsmyth
Copy link
Contributor

If this is in fact an issue, it may still be worth doing, since babel-runtime@5.x is still on core-js@1.x, as is anyone using babel-core/polyfill from babel@5.x.

@loklaan
Copy link
Author

loklaan commented Jun 14, 2016

@loganfsmyth It wouldn't hurt to go ahead with it, yeah. (famous last words)

I'm happy to prove it is an issue. Do you have suggestions, or preferences, for me to provide proof?

@dfreeman
Copy link

dfreeman commented Jul 5, 2016

This definitely appears to be a problem for Babel 5 folks.

If I'm understanding the flow correctly, core-js would need a 1.x branch coming off of the 1.2.6 tag, and then the fix could be backported to that branch and released (as 1.2.7?).

After that, there would need to be a fresh release of the babel-*@5.x packages that include core-js, since (I think) it gets baked into the larger polyfill artifact that's released to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@loklaan @loganfsmyth @dfreeman @zloirock